Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUBBO-3137]: step4 - remove ClusterConstants #4065

Merged
merged 1 commit into from
May 15, 2019
Merged

[DUBBO-3137]: step4 - remove ClusterConstants #4065

merged 1 commit into from
May 15, 2019

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

issue #3137: step4 - remove ClusterConstants

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4065 into master will decrease coverage by 0.03%.
The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4065      +/-   ##
============================================
- Coverage     62.97%   62.94%   -0.04%     
- Complexity      543      544       +1     
============================================
  Files           756      756              
  Lines         32578    32578              
  Branches       5163     5163              
============================================
- Hits          20516    20506      -10     
- Misses         9701     9711      +10     
  Partials       2361     2361
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/rpc/filter/ContextFilter.java 93.33% <ø> (ø) 0 <0> (ø) ⬇️
...o/rpc/cluster/loadbalance/AbstractLoadBalance.java 47.05% <ø> (ø) 0 <0> (ø) ⬇️
.../rpc/cluster/router/condition/ConditionRouter.java 68.05% <ø> (ø) 0 <0> (ø) ⬇️
.../dubbo/registry/integration/RegistryDirectory.java 80.3% <ø> (ø) 0 <0> (ø) ⬇️
...rpc/cluster/configurator/AbstractConfigurator.java 63.15% <ø> (ø) 0 <0> (ø) ⬇️
...che/dubbo/registry/dubbo/DubboRegistryFactory.java 89.74% <ø> (ø) 6 <0> (ø) ⬇️
...apache/dubbo/rpc/cluster/support/ClusterUtils.java 81.63% <ø> (ø) 0 <0> (ø) ⬇️
.../rpc/cluster/router/mock/MockInvokersSelector.java 94.44% <ø> (ø) 0 <0> (ø) ⬇️
.../rpc/cluster/configurator/parser/ConfigParser.java 87.5% <ø> (ø) 0 <0> (ø) ⬇️
...g/apache/dubbo/config/AbstractReferenceConfig.java 94% <ø> (ø) 0 <0> (ø) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update effc2ef...2c53c2a. Read the comment docs.

@beiwei30 beiwei30 requested a review from CrazyHZM May 15, 2019 09:58
CrazyHZM
CrazyHZM approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit 310bf91 into apache:master May 15, 2019
@beiwei30 beiwei30 deleted the issue3137 branch May 15, 2019 10:58
@dubbo-bot dubbo-bot mentioned this pull request May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrazyHZM CrazyHZM CrazyHZM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beiwei30 @codecov-io @CrazyHZM